Repository navigation
fix: validate explicit Codex home ownership - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit
--codex-homecould previously bypass live-writer resolution and queue into an inactive duplicate while another home owned the thread. This change checks every known matching home for implicit and explicit sends, rejects an explicit-home/live-writer conflict without silently switching destinations, and compares the selected writer's PID, process start time, and held advisory lock immediately before queue submission.All-inactive queues now require the deliberate combination
--codex-home ... --allow-inactive-codex-home;--wakeremains an explicit activation opt-in.codexHomeResolutionstays at schema version 1 and adds reason values andownerStartTimeevidence without changing its envelope or status vocabulary. The new flag is forwarded over SSH.The implementation keeps the built-in read-only advisory-lock probe instead of adding a runtime dependency on
codex-unlock@0.1.0, which currently has no supported library exports. This preserves one-process deployment while following the samelive_ownerprinciple and never usingsafeToUnlockas liveness evidence.Validation:
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tests -q— 357 passed, 8 skippedpython3 -m unittest tests.test_docs_i18n -q— 5 passedpython3 -m compileall -q cc_peer.py session_peer.py testspython -m build— sdist and wheel builtCloses #108.